[webkit-reviews] review granted: [Bug 6155] DumpRenderTree should
set a consistent color profile while running :
[Attachment 5167] Proposed patch.
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Mon Dec 19 20:20:43 PST 2005
Darin Adler <darin at apple.com> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 6155: DumpRenderTree should set a consistent color profile while running
http://bugzilla.opendarwin.org/show_bug.cgi?id=6155
Attachment 5167: Proposed patch.
http://bugzilla.opendarwin.org/attachment.cgi?id=5167&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
Since this is a plain C file, functions with no parameters need to be declared
with (void) rather than ().
The fprintf call needs a "\n" at the end, otherwise it will be smushed together
with the next line. Also, no need to put two spaces after those periods. These
messages are so long I think the sentences should go on separate lines.
It's amazing, I'd never heard of %i before, but it turns out to be a synonym
for %d.
No need for the redundant & in the atexit call.
One of the fprintf calls is missing a space after the "stderr,".
The changes to width and height are separate -- not sure why they're here in
this same patch.
There must be some way of generating bitmaps with the appropriate color profile
without changing the system color profile -- we're not even rendering to the
screen!
r=me
More information about the webkit-reviews
mailing list