[webkit-reviews] review denied: [Bug 5744] xmlhttprequest does not apply page encoding after assigning via innerHtml : [Attachment 4911] proposed patch

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Alexey Proskuryakov <ap at nypop.com>'s
request for review:
Bug 5744: xmlhttprequest does not apply page encoding after assigning via
innerHtml
http://bugzilla.opendarwin.org/show_bug.cgi?id=5744

Attachment 4911: proposed patch
http://bugzilla.opendarwin.org/attachment.cgi?id=4911&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I suggest you should change getResponseHeader to return a QString or DOMString,
get rid of the JSLocks and change the getResponseHeader callers that need a
JavaScript string to call jsString explicitly.

Otherwise, this patch looks great.