[webkit-reviews] review granted: [Bug 5875] WebCore+SVG fails to report errors, fails to load external scripts : [Attachment 4869] Addresses Darin's comments (XLinkNames broken out)

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Dec 3 11:16:58 PST 2005


Darin Adler <darin at apple.com> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 5875: WebCore+SVG fails to report errors, fails to load external scripts
http://bugzilla.opendarwin.org/show_bug.cgi?id=5875

Attachment 4869: Addresses Darin's comments (XLinkNames broken out)
http://bugzilla.opendarwin.org/attachment.cgi?id=4869&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
The name xhtmlParseErrorHeader makes it sound like "parse" is a verb, so I
think it should be improved.

The "h3" and "fixed" are both appended immediately after being created, so the
SharedPtr is not needed in those cases.

Do we have layout tests that test these parse error cases?

r=me



More information about the webkit-reviews mailing list