[webkit-reviews] review granted: [Bug 4379] negative margins allowed where they should not : [Attachment 3347] margin calculation patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Aug 11 22:58:02 PDT 2005


Dave Hyatt <hyatt at apple.com> has granted Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 4379: negative margins allowed where they should not
http://bugzilla.opendarwin.org/show_bug.cgi?id=4379

Attachment 3347: margin calculation patch
http://bugzilla.opendarwin.org/attachment.cgi?id=3347&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
r=me.  Might be worth adding a comment that when you fall into the final else
case, auto margins will end up being 0 when you call minWidth and assign into
m_marginLeft and m_marginRight.



More information about the webkit-reviews mailing list