[webkit-reviews] review denied: [Bug 4193] Add pixel-based
regression tests for svg :
[Attachment 3238] Fixed the issues that were discussed in IRC
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Sat Aug 6 10:42:50 PDT 2005
Darin Adler <darin at apple.com> has denied Ben La Monica
<ben.lamonica at gmail.com>'s request for review:
Bug 4193: Add pixel-based regression tests for svg
http://bugzilla.opendarwin.org/show_bug.cgi?id=4193
Attachment 3238: Fixed the issues that were discussed in IRC
http://bugzilla.opendarwin.org/attachment.cgi?id=3238&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
This is great. We'll eventually want to use this for WebKit outside SVG to.
But the framework search path that uses ../../../../WebKitBuild is incorrect.
That hardcodes the particular directory structure you are using and won't work
with people who have a different build results path.
More information about the webkit-reviews
mailing list