[webkit-reviews] review granted: [Bug 3917] DumpKCanvasTree needed for SVG layout testing with KCanvas : [Attachment 3237] DumpKCanvasTree tool, including a few necessary WebCore+SVG changes.

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 3917: DumpKCanvasTree needed for SVG layout testing with KCanvas
http://bugzilla.opendarwin.org/show_bug.cgi?id=3917

Attachment 3237: DumpKCanvasTree tool, including a few necessary WebCore+SVG
changes.
http://bugzilla.opendarwin.org/attachment.cgi?id=3237&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I'm not really happy with the copy and paste approach to developing scripts.
And also I'm worried that there are too many scripts. It's now to the point
where almost half the scripts in the scripts directory are SVG-specific -- I
worked hard to keep the number of scripts needed for WebKit to a minimum and
this is pulling in the other direction. For example, WebKit has two build
scripts, and SVG has a lot more. Having a script named run-webkit-tests-svg
makes it harder to use bash completion to type run-webkit-tests.

All that having been said, I guess it's OK to land this.