[webkit-qt] QtWebKit and QtCreator

[Balazs Kelemen]

On 03/12/2012 12:26 PM, Allan Sandfeld Jensen wrote:
> On Sunday 11 March 2012, Balazs Kelemen wrote:
>> According to my experiences there are two basic issue with qtcreator's
>> interpreting of ifdef sections.
>>
>> 1. it cannot evaluate parametric macros, like USE(X) or ENABLE(Y), that
>> we always use in webkit
>> Fortunately, it can be solved with a one line fix in the macro parser.
>> I'm going to upload this fix to gerrit next week (I should have done it
>> long time ago).
>>
> Actually QtCreator does handle the parametric macros when I have tested it.
> The problem I encountered was that QtCreator can not handle two macro checks
> in a define.
>
> What I mean is that:
>
> #define USE(x) defined(WTF_USE_x)
>
> or
>
> #define USE(x) WTF_USE_x
>
> both work as they should, but QtCreator can not handle
>
> #define USE(x) defined(WTF_USE_x)&&  WTF_USE_x
>
> which is the way the test-macroes are defined in WebKit. I assume your patch
> fixes the double test, if it just adds parametric macros, then I think it is
> already in.
>
> `Allan

I tested it again with this unit test: http://pastebin.com/BMVP5A0P, and 
it seems like QtCreator now understands these macros correctly.


> _______________________________________________
> webkit-qt mailing list
> webkit-qt at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-qt

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-qt/attachments/20120401/8e31baa8/attachment.html>