[webkit-qt] About the fonts used for QtWebKit tests

[Luciano Wolf]

Hi Ossy,

Good job! As this is a small batch of tests compared with the entire
skip list we can deal with it comparing one by one.

I think we can use rebaseline-server to ease our lives. The matter is
that it would be even easier if you provide us your
"WebKitBuild/Release/layout-test-results" directory. Basically you
would need to copy the new expected results into
"webkit/LayoutTests/platform/qt*" (without the patch that skips tests
and change fonts) and run the tests with
"--results-directory=YOUR_DIRECTORY_OF_CHOICE". After that, compress
this resulting directory and we can use "Tools/Scripts/webkit-patch
rebaseline-server OSSY'S_DIRECTORY" to do the rebaseline.

Cheers,
Luciano

On Fri, Jul 6, 2012 at 1:45 PM, Osztrogonac Csaba <oszi at inf.u-szeged.hu> wrote:
> Hi,
>
> I generated png and txt results on my Ubuntu 11.10 with latest Qt5 and WK1
> for all tests skipped by https://trac.webkit.org/changeset/121971 .
>
> You can download them from here:
> - http://build.webkit.sed.hu/x/r121970-with-old-testfonts.tar.gz
> - http://build.webkit.sed.hu/x/r121972-with-new-testfonts.tar.gz
>
> We only need a good tool to help our manual work. :) For example
> a simple script generates a html file contains old and new pngs
> and a simple js to be able to go to the next/previous test, etc.
>
> Let's continue with manual checking and unskipping next week. ;-)
> I think we can start checking these results one by one and unskip correct
> tests and check-in their png and txt result to platform/qt directory. And
> then we should add qt-4.8, qt-5.0-wk2 specific results if it is needed.
>
> br,
> Ossy
>
> Luciano Wolf írta:
>
>> Hi,
>>
>> Today we landed the patches from
>> https://bugs.webkit.org/show_bug.cgi?id=85203.
>>
>> There are 5000+ skipped tests that should be reintegrated as a
>> collective effort.
>> The initial proposal was to take batches of 500 tests. They are skipped
>> inside
>> qt4.8/qt5.0/qt5.0-wk1/qt5.0-wk2 lists so it's interesting to have some
>> control over
>> the ranges that each one will take (like saying "qt5.0 from: testA to:
>> testB").
>>
>> Ossy proposed to have expected results available somewhere (to be
>> confirmed soon),
>> generated by build bots. This will ensure that everybody involved will
>> be using the
>> same expected files.
>>
>> Cheers,
>> Luciano
>>
>>
>>
>> On Thu, May 31, 2012 at 10:46 PM, Raphael Kubo da Costa
>> <rakuco at webkit.org> wrote:
>>>
>>> Osztrogonac Csaba <oszi at inf.u-szeged.hu> writes:
>>>
>>>> Just a question. What kind of (test)fonts use the other ports? Apple?
>>>> GTK? Chromium?
>>>
>>> FWIW, the GTK+ and EFL ports share the same fonts.conf (in
>>> Tools/DumpRenderTree/gtk/fonts/fonts.conf) and the same set of fonts
>>> (available from http://github.com/mrobinson/webkitgtk-test-fonts).
>
> _______________________________________________
> webkit-qt mailing list
> webkit-qt at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-qt