[webkit-qt] Maintaining Qt 4.7 and 4.8 expected results in parallel
oszi at inf.u-szeged.hu
Mon Oct 24 03:52:18 PDT 2011
After Qt 4.8.0-rc1 is released, all QtWebKit buildbots were migrated to Qt 4.8.0-rc1.
And then we landed the patch from https://bugs.webkit.org/show_bug.cgi?id=55036.
After this patch ~6000 test results are different with Qt 4.8.0-rc1 and Qt 4.7.4,
so we won't support layout testing with Qt 4.7.4 anymore. LayoutTests/platform/qt-4.8
was moved to LayoutTests/platform/qt directory and now Qt 4.8 results are the default.
PS. After final releases of Qt 4.8.0 I will update QBAT Virtual Machine too:
Andy Kling írta:
> Hi Ossy,
> I agree, we should wait until Qt 4.8 is released, then land this patch +
> rebaseline LayoutTests/platform/qt.
> Requiring that people manage results from both 4.7 and 4.8 is asking too
> much IMO.
> On a related note, qt-wk2 should already be using qt-4.8 as its
> fallback, but if it's indeed nontrivial, it's not a big deal.
> 2011/9/7 Osztrogonac Csaba <oszi at inf.u-szeged.hu
> <mailto:oszi at inf.u-szeged.hu>>
> Hi QtWebKit developers,
> I ran into a serious problem what we should solve without any pain.
> Here is a bug report with an r+ -ed patch:
> [Qt] FontCache::__createFontPlatformData() is broken, a default font
> is returned even if the family does not match
> After this patch ~5000 layout test result will differ between Qt 4.7
> and 4.8,
> which is absolutly unmaintainable. Additionally WebKit2 builds with
> Qt 5, but
> qt-wk2 platform falls back to qt platform and not qt-4.8/qt platforms.
> I don't know how important is this patch (AFAIK it doesn't block
> QtWebKit2.2 release),
> but I think the best solution is if we wait until Qt 4.8 relase and
> then we drop
> LayoutTests/platform/qt-4.8 platform and declare that now
> means Qt 4.8 results and Qt 4.7 layout test results aren't supported
> If we want to land this patch now, we have to
> - fix run-webkit-tests to be able handle qt-wk2/qt-4.8/qt fallback
> order (It isn't trivial fix.)
> - add +5000 Qt 4.8 specific layout test result into
> - maintain LayoutTests/platform/qt and LayoutTests/platform/qt-4.8
> in parallel ( It is shocking big task !!! )
> What do you think about it? What should we do now?
> Csaba Osztrogonác (Ossy)
> University of Szeged
> webkit-qt mailing list
> webkit-qt at lists.webkit.org <mailto:webkit-qt at lists.webkit.org>
More information about the webkit-qt