[webkit-qt] Fwd: Re: Does QtWebKit API tests need attention?

Zoltan Horvath zoltan at webkit.org
Wed Jun 1 14:02:08 PDT 2011


On Wed, 01 Jun 2011 22:19:57 +0200, Robert Hogan <lists at roberthogan.net>  
wrote:

>
> ----------  Forwarded Message  ----------
>
> Subject: Re: [webkit-qt] Does QtWebKit API tests need attention?
> Date: Wednesday 01 June 2011, 21:18:14
> From: Robert Hogan <lists at roberthogan.net>
> To: Alexis Menard <alexis.menard at openbossa.org>
>
> On Wednesday 01 June 2011 21:09:13 you wrote:
>> On Jun 1, 2011, at 5:05 PM, Robert Hogan wrote:
>> > Hi,
>> >
>> > If we get the API tests passing again, shouldn't we make the
>> > webkit.org build red if an API test fails?
>>
>> That's the idea.
>>
>
> What bothers me about the API tests is that it bails out of the test slot
> on the first failure so there could be other stuff lurking there.
>
> So to prevent further regressions we should mark the current failures
> XFAIL, file bugs for them and do the buildbot stuff required to make an  
> API failure red on build.webkit.org.

Yeap. I think we all agree on this!

> Any reason not to do that?
>
> Ossy - any idea how to promote API test failures to a red?

It's trivial. After we push in expected fails and then the api-tests goes  
green we need to modify 1 line in master bot config and then wms needs to  
run a reconfigure on that.

Zoltan


More information about the webkit-qt mailing list