[webkit-qt] Inline Spell Checking Completish ...

Benjamin Poulain benjamin.poulain at nokia.com
Tue Jul 26 05:58:55 PDT 2011


On 07/19/2011 04:48 AM, ext Lindsay Mathieson wrote:
> Ok, I believe its ready for review - what do I do now? my git clone is here:
>    https://gitorious.org/~blackpaw/webkit/webkit-qt-inline-spell
> Note: I actually modified the QtTestBrowser project so it defined its
> own static platform plugin implementation using sonnet from KDE for
> testing purposes.

If you think it is ready, I suggest you squash the commits, make a 
changelog, and put that on WebKit's bugzilla for review.

You will get more attention from more reviewer that way.

Before uploading, you should take the opportunity to review you own 
code, and fix the coding style.

If you want an informal review beforehand for the style etc, feel free 
to squash the patches and send it to Dawit (I assume he is interested 
:)) and me.


More information about the webkit-qt mailing list