[webkit-qt] Procedure for bug fix ?

Lindsay Mathieson lindsay.mathieson at gmail.com
Sat Aug 20 19:06:09 PDT 2011

My patch for adding inline spell checking has a honking big bug, due
to my misunderstaning of QtPlatformPlugin behaviour, didn't realise it
unloaded the plugins in its destructor, so the following:

bool TextCheckerClientQt::loadSpellChecker()
    if (m_spellChecker)
        return true;

    QtPlatformPlugin platformPlugin;

    if ((m_spellChecker = platformPlugin.createSpellChecker()))
        return true;

    return false;

crashes really badly :) It didn't show up in my testing as I used a
static plugin.

Fixed it - should I just submit my patch for review against the first review?



More information about the webkit-qt mailing list