[webkit-qt] WebKit coding style on Qt files

[Ademar de Souza Reis Jr.]

On Thu, Oct 21, 2010 at 09:33:15AM +0200, Jedrzej Nowacki wrote:
> On Wednesday 20. October 2010 22.10.51 ext Ademar de Souza Reis Jr. wrote:
> > On Wed, Oct 20, 2010 at 05:01:19PM -0300, Ademar de Souza Reis Jr. wrote:
> > > Hi there.
> > > 
> > > from http://trac.webkit.org/wiki/QtWebKitContrib:
> > > "Effective immediately all commits to QtWebKit should use the
> > > WebKit coding style for all files  in the project. That includes
> > > qwebview(.h|cpp), qwebpage(.h|.cpp) and all others. Repeat: the
> > > Qt style should not be used. Thank you."
> > > 
> > > I'm about to submit a patch changing check-webkit-style to
> > > enforce webkit coding style on Qt files. Since that is going to
> > > affect everybody, I just wanted to confirm you're all happy with
> > > such a change. :-)
> > > 
> > > WebKit coding style will be enforced in the following paths:
> > > (currently ignored)
> > > 
> > >     JavaScriptCore/qt/api/
> > >     WebKit/qt/Api/
> > >     WebKit/qt/tests/
> > >     WebKit/qt/examples/
> > 
> > Correction: WebKit/qt/tests will still be ignored since testnames
> > have to follow a specific naming convention with underscores.
> 
> Hi,
> 
> Please notice that there are some other exceptions like q_ptr, d_ptr. There 
> was a mail thread about that:
> https://lists.webkit.org/pipermail/webkit-dev/2010-January/011284.html
> 

Hi Jędrek.

Thanks for pointing this out.

Unfortunately that discussion didn't come to a conclusion. But
check-webkit-style could ignore Qt files when running the '_'
naming rule. I'm updating the patch.

Cheers,
  - Ademar

-- 
Ademar de Souza Reis Jr.
OpenBossa Labs - Instituto Nokia de Tecnologia (INdT)

^[:wq!