[webkit-qt] API review, comments needed!

[tonikitoo (Antonio Gomes)]

On Fri, Mar 5, 2010 at 11:16 AM, Simon Hausmann
<simon.hausmann at nokia.com> wrote:
> Hi,
>
> we just went through the diff of the header files between Qt 4.6's WebKit and
> the trunk. It's a relatively small diff, but nevertheless taking another look
> at it revealed a few interesting issues. Here are the comments and questions
> we collected. Please comment :)
>
>
> QWebFrame::scrollRecursively:
>
>    * Implicit dependency on last mouse move event is bad. The position should
> become an explicit function parameter.
>
>    * The use of "recursion" in the name is confusing, it suggests recursive
> behaviour to child frames. However the behaviour is to continue scrolling the
> parent frames.
>
>    * The documentation does not explain what the return value is.
>
>    * The auto test only checks successful scrolling. It never tests the case
> of the function
>      returning false.

I agree and even I asked for that comment to be added in the bug in
https://bugs.webkit.org/show_bug.cgi?id=32668#c13