[webkit-qt] mobile specific features and defines

Tor Arne Vestbø tor.arne.vestbo at nokia.com
Wed Jun 16 02:46:35 PDT 2010


On 15.06.10 16.13, Simon Hausmann wrote:
> Hi,
>
> In the course of the discussion in
>
> 	https://bugs.webkit.org/show_bug.cgi?id=40062
>
> I'm now wondering if we should perhaps replace all the occurences of Q_WS_S60
> and Q_WS_MAEMO5 with #if PLATFORM(QT_MOBILE) or so and _require_ that when
> building WebKit you have to pass something like

We should not use PLATFORM(QT_MOBILE), ref:

http://trac.webkit.org/wiki/Porting%20Macros%20plan

>      qmake CONFIG+=mobile

I like the idea of a config option to default to enabling various 
ENABLE() and USE() macros, with automatic enabling in various makespecs.

So, the catch-all "mobile" should be a config option on pro-file level, 
which is then translated into granular ENABLE() and USE() macros, not a 
global ENABLE(MOBILE) macro.

Tor Arne



More information about the webkit-qt mailing list