[webkit-qt] Issue with QWebHistory::itemAt(int i) in Qt-4.7b2

Sriram Neelakandan sriram.neelakandan at gmail.com
Tue Aug 17 08:04:07 PDT 2010


Dear List,

QWebHistoryItem QWebHistory::itemAt(int i) const
{
    if (i < 0 || i >= count())
        priv = new QWebHistoryItemPrivate(0);
..
}

As seen a null item is prepared for any -ve value; which prevents
probing the Back Entries of WebCore::BackForwardList

I did look up the latest code on GIT
http://www.qt.gitorious.org/qt/qt/blobs/4.7/src/3rdparty/webkit/WebKit/qt/Api/qwebhistory.cpp#line444
It has the check still in place;
Same at http://trac.webkit.org/browser/trunk/WebKit/qt/Api/qwebhistory.cpp

However Qt-4.5.2 did not have this check
I think it should be  something like

QWebHistoryItem QWebHistory::itemAt(int i) const
{
   if (i < -count() || i >= count())
        priv = new QWebHistoryItemPrivate(0);
...
}

Is this a bug ? should i report this on bugs.webkit.org ?
Or am i missing something obvious here ?
thanks
-- 
Sriram Neelakandan
Author - Embedded Linux System Design And Development
(http://tinyurl.com/2doosu)


More information about the webkit-qt mailing list