[webkit-help] Wincairo build for 32 bit

[Thomas Brodt]

Hi Fujii,

you are my hero of the day!

Thank you very much for your patch and also your fixes regarding the 
jpeg2000encoder etc!

I upgraded to the most recent revision today to get all your already 
committed changes. Now I only have the two uncommitted changes left, 
with the win32 WebKitRequirements zip and the place where you commented 
out the WebCore_LIBRARY_TYPE statement in the wincairo cmake file.

The build doesn't work yet, however, the only error left I got is

98>C:\Webkit\WebKit\WebKitBuild\Release\WebCore\DerivedSources\JSAudioTrack.cpp(132,1): 
error C2187: syntax error: 'static' was unexpected here.........

for 41 files, all named JS*.cpp that define a static const like e.g. 
this one:

static const HashTableValue JSAudioTrackPrototypeTableValues[] =
{.....}

Can you tell if this is an arch issue for 32/64, wincairo, or compiler 
issue or C level issue? I am using VS 2019 with C compiler 
identification is MSVC 19.25.28611.0

Thanks for any hint

Thomas


Am 22.07.2020 um 23:33 schrieb Fujii Hironori:

> I attached my hacky patch in the ticket. Enjoy!
> https://bugs.webkit.org/show_bug.cgi?id=210192#c1
>
> Your WebKitRequirementsWin32.zip works nicely. Thank you, Don.
>
> On Wed, Jul 22, 2020 at 6:53 PM Thomas Brodt 
> <thomas.brodt.lists at porabo.ch <mailto:thomas.brodt.lists at porabo.ch>> 
> wrote:
>
>     Hi Fujii,
>
>     thanks for your reply! I knew it wouldn't be so easy. Especially
>     as I am not a regular C developer that is familiar with all the
>     tools in use in WebKit.
>
>     I already found the 32 bit version of the WebKitRequirements is
>     available in parallel to the 64 bit version, which is great
>     (thanks Don!) That's why I already created bug 210192 a while ago,
>     but since then couldn't go on with it.
>
>     When I have some more time than at the moment, I will go ahead and
>     find out if I can build my 32bit version.
>
>     You say that currently WinCairo doesn't support 32bit. Is this
>     because of some technical reason that makes 32bit impossible, or
>     is it because wincairo is going forward in 64bit only, and just
>     nobody cares for a 32bit version, which could however be possible?
>
>     Am 17.07.2020 um 23:09 schrieb Fujii Hironori:
>>     I don't know the "last known good" revision.
>>
>>     Even though the latest WinCairo doesn't support 32bit version,
>>     Don publishes WebKitRequirementsWin32.zip every time he releases
>>     a new WebKitRequirements, and the latest WinCairo is still
>>     maintaining WebKit1.
>>     https://github.com/WebKitForWindows/WebKitRequirements/releases/tag/v2020.07.01
>>
>>     As far as I know, no one has tried WebKitRequirementsWin32.zip.
>>     But it seems worth to try to you. Good luck.
>>
>>     -- Fujii
>>
>>     On Sat, Jul 18, 2020 at 3:02 AM Thomas Brodt
>>     <thomas.brodt.lists at porabo.ch
>>     <mailto:thomas.brodt.lists at porabo.ch>> wrote:
>>
>>         Hi
>>
>>         for a legacy project I would need a 32 bit version of the
>>         wincairo port.
>>         (yes, I know...)
>>
>>         Is there a "last known good" version before the switch to 64
>>         bit? Could
>>         anyone give me any pointer how to find out? I tried to find
>>         it with trac
>>         but was unable to.
>>
>>         Thanks a lot!
>>
>>         Thomas
>>
>>         _______________________________________________
>>         webkit-help mailing list
>>         webkit-help at lists.webkit.org
>>         <mailto:webkit-help at lists.webkit.org>
>>         https://lists.webkit.org/mailman/listinfo/webkit-help
>>
>>
>>     _______________________________________________
>>     webkit-help mailing list
>>     webkit-help at lists.webkit.org  <mailto:webkit-help at lists.webkit.org>
>>     https://lists.webkit.org/mailman/listinfo/webkit-help
>
>
> _______________________________________________
> webkit-help mailing list
> webkit-help at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-help
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-help/attachments/20200723/c76304e6/attachment.htm>