[webkit-help] Styling issue with -expected.png files during svn_create_patch and fails on build bots.[Win-7/Cygwin]

[SravanKumar Sandela]

Hi Julian,

Thanks for the response, but i have done that too. Infact i tried sneaking
in to scripts responsible for creating the patch and applying the patch,
following is my observation(which i have posted on
https://bugs.webkit.org/show_bug.cgi?id=78684)

i found that when we run 'svn-create-patch', this script executes svn
diff on the png file in one of the iterations. When i tried to do the
same exclusively from cygwin command line and normal command prompt,
i.e,
svn diff --diff-cmd diff LayoutTests/platform/win/fast/forms/fieldset-legend-
padding-unclipped-fieldset-border-expected.png

i see that following as the footer
___________________________________________________________________
Added: svn:mime-type
## -0,0 +1 ##
+image/png

And on chasing .Tools/Scripts/svn-apply i found that script is
actually dying because it does'nt get propertyValue(from VCSUtils.pm
file), as the condition in while loop is not getting satisisfied
(while (defined($_) && /$svnPropertyValueStartRegEx/) {). It is
expecting any one of /^   (\+|-|Merged|Reverse-merged) ([^\r\n]+)/
But $_ is ## -0,0 +1 ##.

But since this is a new file it will never be Merged or
Reverse-merged, and i dont see any + or - with mime-type:image/png .

Hence my patch will never go through style bots, and i am sorry for
uploading so many failing patches.

I just want to know if my cygwin settings are wrong? or svn
configuration settings are wrong? or do i have to leave this and find
an alternate method to upload the patch?.

Please kindly let me know what else can be done to upload the patch.

Initially i thought its a svn diff related problem but since everybody is
uploading patches, i  am holding back on that assumption. i tried to look
at change logs for some references on patch, but i found that almost all of
them are using git diff, so it dint help me much.

Can u please  suggest what is the alternative to upload the patch.

-Sravan.

On Mon, Feb 27, 2012 at 9:24 PM, Julien Chaffraix <
julien.chaffraix at gmail.com> wrote:

> Hi,
>
> > While trying to create patch that involves uploading a
> "xyz-expected.png", i
> > am constantly facing a style issue as follows(in patch)
> >
> > Property changes on:
> >
> LayoutTests/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png
> > ___________________________________________________________________
> > Added: svn:executable
> > ## -0,0 +1 ##
> >
> >
> > and it fails on build bot with following error
> >
> > Failed to find the property value for the SVN property "svn:executable":
> "##
> > -0,0 +1 ##
> > ". at /mnt/git/webkit-chromium-ews/Tools/Scripts/VCSUtils.pm line 1184,
> > <ARGV> line 112.
>
> Is it possible that you need to apply the advice about automatically
> setting the right svn:mime-type [1]?
>
> Hope it helps,
> Julien
>
> [1] http://trac.webkit.org/wiki/UsingGitWithWebKit#Misc.TipsandTricks
> (ignore the git parts and look at the svn:mime trick)
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-help/attachments/20120228/a5a452d7/attachment-0001.html>