[webkit-gtk] [PATCH] Fix clang version checking in configure

[Žan Doberšek]

The patch looks OK. Can you please create a new bug in the WebKit Bugzilla
and upload the patch there, also including a ChangeLog entry?
Someone else can do it for you otherwise, with proper attribution included.

Cheers,
Zan


On Tue, Nov 26, 2013 at 12:29 AM, Jeremy Huddleston Sequoia <
jeremyhu at macports.org> wrote:

> FYI, this bug (and fix) are still relevant to version 2.2.2
>
> --Jeremy
>
> On Nov 10, 2013, at 17:49, Jeremy Huddleston Sequoia <
> jeremyhu at macports.org> wrote:
>
> > The logic to verify >= clang-3.2 is incorrect:
> >  1) It does not correctly check Apple clang versions
> >  2) It forces minor version >= 2 even when major version > 3 (eg 4.0
> will fail)
> >
> > Patch included.
> >
> > <clang-check.patch>
> >
> > --- Source/autotools/CheckSystemAndBasicDependencies.m4.orig  2013-11-10
> 17:44:57.000000000 -0800
> > +++ Source/autotools/CheckSystemAndBasicDependencies.m4       2013-11-10
> 17:45:57.000000000 -0800
> > @@ -87,7 +87,7 @@ AC_COMPILE_IFELSE([AC_LANG_PROGRAM([
> > #endif
> > ])], [c_compiler="gcc"], [])
> > AC_COMPILE_IFELSE([AC_LANG_PROGRAM([
> > -#if !(defined(__clang__) && __clang_major__ >= 3 && __clang_minor__ >=
> 2)
> > +#if !(defined(__clang__) && (__apple_build_version__ >= 4250024 ||
> (!defined(__apple_build_version__) && (__clang_major__ > 3 ||
> (__clang_major__ == 3 && __clang_minor__ >= 2)))))
> > #error Not a supported Clang compiler
> > #endif
> > ])], [c_compiler="clang"], [])
> > @@ -106,7 +106,7 @@ AC_COMPILE_IFELSE([AC_LANG_PROGRAM([
> > #endif
> > ])], [cxx_compiler="g++"], [])
> > AC_COMPILE_IFELSE([AC_LANG_PROGRAM([
> > -#if !(defined(__clang__) && __clang_major__ >= 3 && __clang_minor__ >=
> 2)
> > +#if !(defined(__clang__) && (__apple_build_version__ >= 4250024 ||
> (!defined(__apple_build_version__) && (__clang_major__ > 3 ||
> (__clang_major__ == 3 && __clang_minor__ >= 2)))))
> > #error Not a supported Clang++ compiler
> > #endif
> > ])], [cxx_compiler="clang++"], [])
> >
> > _______________________________________________
> > webkit-gtk mailing list
> > webkit-gtk at lists.webkit.org
> > https://lists.webkit.org/mailman/listinfo/webkit-gtk
>
>
> _______________________________________________
> webkit-gtk mailing list
> webkit-gtk at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-gtk
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-gtk/attachments/20131202/8e7dee00/attachment-0001.html>