<div dir="ltr">The patch looks OK. Can you please create a new bug in the WebKit Bugzilla and upload the patch there, also including a ChangeLog entry?<div>Someone else can do it for you otherwise, with proper attribution included.</div>
<div><br></div><div>Cheers,</div><div>Zan<br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Nov 26, 2013 at 12:29 AM, Jeremy Huddleston Sequoia <span dir="ltr"><<a href="mailto:jeremyhu@macports.org" target="_blank">jeremyhu@macports.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">FYI, this bug (and fix) are still relevant to version 2.2.2<br>
<br>
--Jeremy<br>
<div><div class="h5"><br>
On Nov 10, 2013, at 17:49, Jeremy Huddleston Sequoia <<a href="mailto:jeremyhu@macports.org">jeremyhu@macports.org</a>> wrote:<br>
<br>
> The logic to verify >= clang-3.2 is incorrect:<br>
> 1) It does not correctly check Apple clang versions<br>
> 2) It forces minor version >= 2 even when major version > 3 (eg 4.0 will fail)<br>
><br>
> Patch included.<br>
><br>
</div></div>> <clang-check.patch><br>
><br>
> --- Source/autotools/CheckSystemAndBasicDependencies.m4.orig 2013-11-10 17:44:57.000000000 -0800<br>
> +++ Source/autotools/CheckSystemAndBasicDependencies.m4 2013-11-10 17:45:57.000000000 -0800<br>
> @@ -87,7 +87,7 @@ AC_COMPILE_IFELSE([AC_LANG_PROGRAM([<br>
> #endif<br>
> ])], [c_compiler="gcc"], [])<br>
> AC_COMPILE_IFELSE([AC_LANG_PROGRAM([<br>
> -#if !(defined(__clang__) && __clang_major__ >= 3 && __clang_minor__ >= 2)<br>
> +#if !(defined(__clang__) && (__apple_build_version__ >= 4250024 || (!defined(__apple_build_version__) && (__clang_major__ > 3 || (__clang_major__ == 3 && __clang_minor__ >= 2)))))<br>
> #error Not a supported Clang compiler<br>
> #endif<br>
> ])], [c_compiler="clang"], [])<br>
> @@ -106,7 +106,7 @@ AC_COMPILE_IFELSE([AC_LANG_PROGRAM([<br>
> #endif<br>
> ])], [cxx_compiler="g++"], [])<br>
> AC_COMPILE_IFELSE([AC_LANG_PROGRAM([<br>
> -#if !(defined(__clang__) && __clang_major__ >= 3 && __clang_minor__ >= 2)<br>
> +#if !(defined(__clang__) && (__apple_build_version__ >= 4250024 || (!defined(__apple_build_version__) && (__clang_major__ > 3 || (__clang_major__ == 3 && __clang_minor__ >= 2)))))<br>
> #error Not a supported Clang++ compiler<br>
> #endif<br>
> ])], [cxx_compiler="clang++"], [])<br>
<div class="HOEnZb"><div class="h5">><br>
> _______________________________________________<br>
> webkit-gtk mailing list<br>
> <a href="mailto:webkit-gtk@lists.webkit.org">webkit-gtk@lists.webkit.org</a><br>
> <a href="https://lists.webkit.org/mailman/listinfo/webkit-gtk" target="_blank">https://lists.webkit.org/mailman/listinfo/webkit-gtk</a><br>
<br>
</div></div><br>_______________________________________________<br>
webkit-gtk mailing list<br>
<a href="mailto:webkit-gtk@lists.webkit.org">webkit-gtk@lists.webkit.org</a><br>
<a href="https://lists.webkit.org/mailman/listinfo/webkit-gtk" target="_blank">https://lists.webkit.org/mailman/listinfo/webkit-gtk</a><br>
<br></blockquote></div><br></div></div></div>