[webkit-gtk] WebKit2 zoom API (II)

[Xan]

On Thu, Feb 2, 2012 at 6:36 PM, Carlos Garcia Campos <cgarcia at igalia.com> wrote:
>> Does not look like the most elegant API in the world to me.
>
> Agree, problem is, what is the effective zoom initially when both scale
> factor are 1?

Yes. I guess in this case we would need an enum like NONE/TEXT/PAGE,
with NONE used when both scale factors are at their default value.

>
>>  I suppose
>> that if we consider a getter of the active zoom useful it can always
>> be written later using that algorithm inside WebKitGTK+ though.
>
> In any case, as I said, most of the apps use one scale factor or the
> other, so they don't need to know the effective one. Apps that want to
> scale text will use set/get_text_zoom_level and apps that want to scale
> page content will use gt/set_page_zoom_level. An apps that have a
> preference to control it, already know the effective zoom too.

Probably, yes. In any case as I said I think it's safe to see whether
the method I mentioned is requested or not before adding it, since it
seems possible to add it after the fact.

>
>> Xan
>>
>
> --
> Carlos Garcia Campos
> http://pgp.rediris.es:11371/pks/lookup?op=get&search=0xF3D322D0EC4582C3