[webkit-gtk] WK2: Adapting the Policy Decision Framework for Geolocation
Mario Sanchez Prada
msanchez at igalia.com
Tue Apr 10 04:35:57 PDT 2012
[sorry for the delay in the answer, being on holidays since wednesday]
On Thu, 2012-04-05 at 11:27 +1200, Gavin Lambert wrote:
> Quoth Carlos Garcia Campos:
> > Just because it makes the API simpler, using a single signal in
> > WebKitWebView to handle policy decisions. The geolocation API is quite
> > straightforward, you get a request and you can allow or deny it, so we
> > can just use the current policy-decision signal.
> I haven't really been following the WebKit2 API discussions, so maybe I have the wrong end of the stick here... but in my opinion, using a single signal for multiple kinds of policy decisions and then having to disambiguate between them inside the signal handler is a weaker API than having separate signals for each separate type of decision. Especially once inheritance comes into play and some intermediate class wants to handle one type of decision but not another.
Gavin explained pretty well one of the reasons why I think keeping a
specific signal, separated from the policy decision framework, could be
better in this case.
More information about the webkit-gtk