[webkit-gtk] And another not-quite-bug...

Bob Murphy bobert at lavitanuova.com
Mon Sep 12 21:35:30 PDT 2011


In all the example code I've been able to find for DOM event handlers using webkit_dom_event_target_add_event_listener(), the callback routines all return a gboolean.

But it's impossible to figure out what a TRUE or FALSE return is supposed to accomplish - and there's a good reason for that. GObjectEventListener::handleEvent() casts the callback routines to GObjectEventListenerCallback when invoking them, thus discarding any return value.

I think it would be a good idea to change the callbacks in WebKitGTK and in Epiphany to use void returns so other folks aren't as confused as I.

And if there's no objection, I'll be happy to submit those patches.

Best regards,
Bob



More information about the webkit-gtk mailing list