[webkit-gtk] possible solutions for local files on win32

Jan Michael Alonzo jmalonzo at gmail.com
Tue Nov 3 02:26:27 PST 2009


On Tue, Nov 3, 2009 at 11:20 AM, Josip <josip at pisoj.com> wrote:

> Hi again!
> Found some possible solutions for those who have problems with local files
> on win32 due to mime-share-info misconfiguration or missing dependencies
> etc.
> As g_file_info_get_content_type() returns just file extension (like
> ".html") and win32 use those to determine mime type can we use
> g_content_type_get_mime_type() on them like in attachment.
> It works for me, load html files (with right encoding), images etc...
>

Hi Josip

Have you tried running some of the layout tests to see if your patch works
as expected?



> Or should we rather check for return type on runtime and use those if
> returned type is file extension (in case some really have full working
> version)?
>

I think your patch is ok. But can you please file a bug at
http://bugs.webkit.org and attach your patch in the bug report?

Here's a guideline on how to contribute code to help you out:
http://webkit.org/coding/contributing.html.

Thanks!

Jan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-gtk/attachments/20091103/0e0e4762/attachment.html>


More information about the webkit-gtk mailing list