[webkit-efl] async keyword in WebKit2 EFL APIs

[Daniel Juyung Seo]

+1 from my side.

It is a good catch.
As 'async' is not a feature/module name and 'async' modifies the verb
'get', xxx_async_get sounds more like EFL.

Thanks!

Daniel Juyung Seo (SeoZ)



On Tue, Mar 18, 2014 at 1:48 AM, ryuan Choi <ryuan.choi at webkit.org> wrote:

> Hi, efl-folks,
>
> Today, I landed ewk_application_cache_manager (
> https://bugs.webkit.org/show_bug.cgi?id=102853)
>
> While making it, we have some discussion about *async* in APIs.
>
> While we used xxx_async_yyy_get (xxx as module, yyy as functionality),
> other EFL libraries looks prefered xxx_yyy_async_get() style.
>
> For example, ewebkit has
> ewk_cookie_manager_async_accept_policy_get
> ewk_cookie_manager_async_hostnames_with_cookies_get
> ...
>
> while EFL has
> efreet_menu_async_get
> ethumb_client_thumb_async_get
> ethumb_client_thumb_async_cancel
>
> So, for the consistency with EFL libraries. we'd better to use
> xxx_yyy_async_zzz()
>
> If nobody object about it, I want to fix ewebkit APIs including
> ewk_application_cache_manager_origins_get.
>
> Best Regards,
> Ryuan Choi
>
> _______________________________________________
> webkit-efl mailing list
> webkit-efl at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-efl
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-efl/attachments/20140318/7dfe8c77/attachment.html>