<div dir="ltr"><div><div>+1 from my side.<br><br></div><div>It is a good catch.<br></div>As 'async' is not a feature/module name and 'async' modifies the verb 'get', xxx_async_get sounds more like EFL.<br>
<br></div>Thanks!<br><br>Daniel Juyung Seo (SeoZ)<br><br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Mar 18, 2014 at 1:48 AM, ryuan Choi <span dir="ltr"><<a href="mailto:ryuan.choi@webkit.org" target="_blank">ryuan.choi@webkit.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div><div><div><div><div>Hi, efl-folks,<br><br></div>Today, I landed ewk_application_cache_manager (<a href="https://bugs.webkit.org/show_bug.cgi?id=102853" target="_blank">https://bugs.webkit.org/show_bug.cgi?id=102853</a>)<br>
<br></div>While making it, we have some discussion about *async* in APIs.<br><br></div>While we used xxx_async_yyy_get (xxx as module, yyy as functionality), other EFL libraries looks prefered xxx_yyy_async_get() style.<br>
<br></div><div>For example, ewebkit has<br>ewk_cookie_manager_async_accept_policy_get<br>ewk_cookie_manager_async_hostnames_with_cookies_get<br>...<br><br></div><div>while EFL has <br>efreet_menu_async_get<br>ethumb_client_thumb_async_get<br>
ethumb_client_thumb_async_cancel<br><br></div>So, for the consistency with EFL libraries. we'd better to use xxx_yyy_async_zzz()<br><br></div>If nobody object about it, I want to fix ewebkit APIs including ewk_application_cache_manager_origins_get.<br>
<br></div>Best Regards,<br></div>Ryuan Choi<br></div>
<br>_______________________________________________<br>
webkit-efl mailing list<br>
<a href="mailto:webkit-efl@lists.webkit.org">webkit-efl@lists.webkit.org</a><br>
<a href="https://lists.webkit.org/mailman/listinfo/webkit-efl" target="_blank">https://lists.webkit.org/mailman/listinfo/webkit-efl</a><br>
<br></blockquote></div><br></div>