[webkit-efl] Common ref and unref functions for EFL WK2 objects

[Byung-Woo Lee]

I also think that the basic idea is nice, but I have simple question about the implementation.

> typedef Ewk_Ref_Counted Ewk_Back_Forward_List_Item;
I think that, this will be in ewk_back_forward_list.h header file. and the header file will be used in the ewk_back_forward_list.cpp
with ewk_back_forward_list_private.h file which has Ewk_Back_Forward_List_Item as class.

Is there any problem on this? (I think there can be some compile error)

Byungwoo.

------- Original Message -------
Sender : Gyuyoung Kim<gyuyoung at gmail.com>
Date : 2012-10-30 21:37 (GMT+09:00)
Title : Re: [webkit-efl] Common ref and unref functions for EFL WK2 objects

Though I still need to see this patches, your work looks good to me. If there is any problems when our internal source uses this new struct or problems occur, I will let you guys know that. 


Gyuyoung.  
  


On Tue, Oct 30, 2012 at 9:00 PM, Kangil Han <kangil.han at samsung.com> wrote:

Hi Mikhail,


> BTW, WK2 C API has geneiric ref/unfer functions and GTK also does.

Would you please let us know more specific information on this, i.e. wiki
url or something that help our understanding?

Kind regards,
Kangil Han


-----Original Message-----
From: webkit-efl-bounces at lists.webkit.org
[mailto:webkit-efl-bounces at lists.webkit.org] On Behalf Of Pozdnyakov,
Mikhail
Sent: Tuesday, October 30, 2012 7:05 PM
To: webkit-efl at lists.webkit.org
Subject: [webkit-efl] Common ref and unref functions for EFL WK2 objects

Hi,

I've already mentioned the proposal at
http://lists.webkit.org/pipermail/webkit-efl/2012-October/000393.html

but think (and since nobody replied so far) it deserves new topic and new
thread, so duplicating proposal again here.

As all the ref-counting EWK classes are inherited from WTF::RefCounted
it is possible now to have generic REF/UNREF functions in the public API
instead of
having separate pair of such functions for every object.

To say in more details we could introduce
struct Ewk_Ref_Counted Ewk_Ref_Counted;
and following generic functions:
EAPI Ewk_Ref_Counted*  ewk_ref(Ewk_Ref_Counted*);
EAPI  ewk_unref(Ewk_Ref_Counted*);

then Ewk_Back_Forward_List_Item  might be declared for instance as

typedef Ewk_Ref_Counted Ewk_Back_Forward_List_Item;

so that it's clear that Ewk_Back_Forward_List_Item is ref-countable
(or we could just mention in docs that given object is ref counted).

Would like to hear your opinion about this proposal.

BTW, WK2 C API has geneiric ref/unfer functions and GTK also does.

BR,
Mikhail
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

_______________________________________________
webkit-efl mailing list
webkit-efl at lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-efl

_______________________________________________
webkit-efl mailing list
webkit-efl at lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-efl






-- 
Gyuyoung Kim 
SW Engineer, WebKit EFL
Email : gyuyoung.kim at webkit.org
Phone : +82 10 9530 0209