[webkit-efl] How about switching backing store of DRT to single?

Gyuyoung Kim gyuyoung at gmail.com
Sun Oct 7 19:38:03 PDT 2012


I also agree with Kenneth opinion. It would be good to use we're going to
use actually. However, in our case, I don't much mind to use SBS in WK1 DRT
because WK2 is target to ship.
Beside we need to support pixel-test, so I don't mind to use SBS in WK1 to
support pixel-test. When pixel-test is stable on EFL port, then, probably
we can consider it on TBS.

Gyuyoung.

On Mon, Oct 8, 2012 at 10:43 AM, ryuan Choi <ryuan.choi at gmail.com> wrote:

> I filed a patch in https://bugs.webkit.org/show_bug.cgi?id=98591
>
> Cheers
> Ryuan Choi
>
> 2012/10/6 Kenneth Rohde Christiansen <kenneth.christiansen at gmail.com>
>
>> It is for WebKit1 so I don't really care much, but it is always best
>> testing with the configuration you are actually going to ship
>>
>> Cheers
>> Kenneth
>>
>> On Fri, Oct 5, 2012 at 4:51 PM, ryuan Choi <ryuan.choi at gmail.com> wrote:
>> > Dear webkit-efl developers,
>> >
>> > I want your opinion about switching default backing store of
>> > DRT(DumpRenderTree/Efl) to `single` instead of `tiled`.
>> > Now, default is `tiled` and DRT_USE_SINGLE_BACKING_STORE environment is
>> used
>> > to switch.
>> >
>> > As you may know, DRT/Efl can not pass some pixel tests.
>> > Although it is because of many bugs, I think that one of major reason is
>> > that DRT/Efl calls paint() directly instead of capturing.
>> >
>> > So I created https://bugs.webkit.org/show_bug.cgi?id=79853 but it was
>> > reverted because of many regressions.
>> > In my poor analyze, webkit/efl can not capture the webivew now because
>> > webkit/efl does not draw mockScrollbar as calling paintContents()
>> instead of
>> > paint()
>> >
>> > One simple solution is adding logic to paint scrollbar in
>> > _ewk_view_tiled_render_cb (ewk_view_tiled.cpp)
>> > But, I am not sure that painting scrollbar for DRT in tile is
>> reasonable.
>> > When we designed tiled backingstore, we focused performance and I think
>> that
>> > painting scrollbar is not a role of tile.
>> >
>> > Instead, I suggest using ewk_view_single for DRT.
>> > ewk_view_single is simple and similar with other ports.
>> >
>> > I think that ewk_view_single is more suitable for layout test.
>> > Could you let me know your opinion?
>> >
>> > Regards,
>> > Ryuan Choi
>> >
>> >
>> >
>> >
>> >
>> > _______________________________________________
>> > webkit-efl mailing list
>> > webkit-efl at lists.webkit.org
>> > http://lists.webkit.org/mailman/listinfo/webkit-efl
>> >
>>
>>
>>
>> --
>> Kenneth Rohde Christiansen
>> Senior Engineer, WebKit, Qt, EFL
>> Phone  +45 4093 0598 / E-mail kenneth at webkit.org
>>
>> ﹆﹆﹆
>>
>
>
> _______________________________________________
> webkit-efl mailing list
> webkit-efl at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo/webkit-efl
>
>


-- 
Gyuyoung Kim
SW Engineer, WebKit EFL
Email : gyuyoung.kim at webkit.org
Phone : +82 10 9530 0209
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-efl/attachments/20121008/485df85c/attachment.html>


More information about the webkit-efl mailing list