[webkit-efl] Fwd: Re: Removing ewk_{init, shutdown}'s duplicated works with RunLoopEfl.cpp

[EunMi Lee]

Dear all,

I have to say that I can not change ewk_{init, shutdown} to local function from API,
because ecore should be initialized before using ecore_pipe with latest ecore library.
The ecore_pipe starts to use eina_mempool to allocate the memory recently, and eina_init is done in the ecore_init,
so we have to call ecore_init before using ecore_pipe.

The ecore_pipe is created in the Source/WTF/wtf/efl/MainThreadEfl.cpp's initializeMainThreadPlatform(),
initializeMainThreadPlatform() is called when we use the WKString and the WKString is used in the WebKitTestRunner before creating WebContext.
So, I will maintain the ewk_{init, shutdown} as an API and prepare patch for that again.
https://bugs.webkit.org/show_bug.cgi?id=97173

BR,
Eunmi Lee
------- Original Message -------
Sender : 이은미<eunmi15.lee at samsung.com> S4(선임)/선임/차세대Computing Lab(S/W센터)/삼성전자
Date : 2012-09-25 11:16 (GMT+09:00)
Title : Re: [webkit-efl] Removing ewk_{init, shutdown}'s duplicated works with RunLoopEfl.cpp

Dear Kangil and Chris,

Both of you want to process {init, shutdown} in the webkit, not applications. :)
I will prepare patch for that.

Thanks,
Eunmi Lee
------- Original Message -------
Sender : 한강일 S5(책임)/책임/차세대S/W개발그룹(무선)/삼성전자
Date : 2012-09-24 19:18 (GMT+09:00)
Title : RE: Re: [webkit-efl] Removing ewk_{init, shutdown}'s duplicated works with RunLoopEfl.cpp

Chris, I’ve consistently expressed my opinion from the application side point of view.

It is true that ewk_context does initializing stuff.
However, in application, we can just trigger ewk_view_add.
This looks great on my side.

- Kangil Han

From: Dumez, Christophe [mailto:christophe.dumez at intel.com] 
Sent: Monday, September 24, 2012 4:30 PM
To: kangil.han at samsung.com
Cc: eunmi15.lee at samsung.com; webkit-efl at lists.webkit.org
Subject: Re: Re: [webkit-efl] Removing ewk_{init, shutdown}'s duplicated works with RunLoopEfl.cpp

Kangil, I don't understand your point. As Eunmi said, it makes more sense to do the Ewk initialization in ewk_context.

Doing the Ewk initialization in ewk_view may be problematic because the client can create a ewk_context before creating a ewk_view.
However, it is impossible to construct a ewk_view without a ewk_context being constructed first. The ewk_view constructor will start by creating a ewk_context if it is not provided with one.

Kr,
On Mon, Sep 24, 2012 at 10:20 AM, Kangil Han wrote:
I vote to ‘by contructing a view’!

From: Dumez, Christophe [mailto:christophe.dumez at intel.com] 
Sent: Monday, September 24, 2012 4:07 PM
To: eunmi15.lee at samsung.com
Cc: 한강일; webkit-efl at lists.webkit.org
Subject: Re: Re: [webkit-efl] Removing ewk_{init, shutdown}'s duplicated works with RunLoopEfl.cpp


On Mon, Sep 24, 2012 at 9:12 AM, EunMi Lee wrote:
Dear Chris and webkit-efl folks,

I've got your point and we have no reason to rely on RunLoop to do the initialization.
We just need "location" to do initialization for EFL.
I don't matter to use ewk_{init,shutdown} or RunLoop, but I don't want to force applications to call ewk_{init, shutdown}.
In the WK1, applications should use ewk_{init, shutdown} API but in the WK2 we can do that inside webkit becasue we have ewk_context which is careted before creating ewk_view.

In conclusion, my opinions are as follows,
- Use ewk_{init, shutdown} to do initialization. (because there is no reason to rely on RunLoop and we already have ewk_{init, shutdown})
- Do not open ewk_{init, shutdown} as an API and just call in the ewk_context. (in order to not force applications to call them)

How do you think?

I don't have any strong objection against moving the Ewk initialization code to ewk_context. It is a bit less error prone and hopefully, the client will not call any ewk function before a context initialized (either explicitly or by constructing a view).

Kr,
-- 
Christophe Dumez
Linux Software Engineer, PhD
Intel Finland Oy - Open Source Technology Center



-- 
Christophe Dumez
Linux Software Engineer, PhD
Intel Finland Oy - Open Source Technology Center
_______________________________________________
webkit-efl mailing list
webkit-efl at lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-efl