No subject

we should move towards C++ style for our Ewk classes.
However, it appears the majority of people prefers *not* to use pimpl
pattern. The main reason is that with the current pimpl proposal, some of
the logic is in C functions, and the rest is in C++ methods.
Conceptually, it feels cleaner to have all the logic in one place (on C++
side). As a result, public C functions become 1-liners that merely call
their corresponding C++ methods.

One drawback we need to keep in mind is that we may need to duplicates C++
methods sometimes (if needed) to return (or accept) different types but I
believe this is acceptable.

Thanks a lot to everyone involved in the discussion. This was very useful
and this will definitely benefit our port.

Mikhail and I will probably start porting the Ewk classes in the new couple
of days via:
https://bugs.webkit.org/show_bug.cgi?id=99696

Kr,
-- 
Christophe Dumez
Linux Software Engineer, PhD
Intel Finland Oy - Open Source Technology Center

--047d7b15a6a7b4715004cc68f1d9
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Hi,<br><br>Ok, I think there was a good back and forth. I believe it is tim=
e to go in one direction now.<br><br>From what I have heard (online and off=
line), it seems everyone agrees that we should move towards C++ style for o=
ur Ewk classes.<br>
However, it appears the majority of people prefers <b>not</b> to use pimpl =
pattern. The main reason is that with the current pimpl proposal, some of t=
he logic is in C functions, and the rest is in C++ methods.<br>Conceptually=
, it feels cleaner to have all the logic in one place (on C++ side). As a r=
esult, public C functions become 1-liners that merely call their correspond=
ing C++ methods.<br>
<br>One drawback we need to keep in mind is that we may need to duplicates =
C++ methods sometimes (if needed) to return (or accept) different types but=
 I believe this is acceptable.<br><br>Thanks a lot to everyone involved in =
the discussion. This was very useful and this will definitely benefit our p=
ort.<br>
<br>Mikhail and I will probably start porting the Ewk classes in the new co=
uple of days via:<br><a href=3D"https://bugs.webkit.org/show_bug.cgi?id=3D9=
9696">https://bugs.webkit.org/show_bug.cgi?id=3D99696</a><br><br>Kr,<br>-- =
<br>
Christophe Dumez<br>Linux Software Engineer, PhD<br>Intel Finland Oy - Open=
 Source Technology Center<br><br>

--047d7b15a6a7b4715004cc68f1d9--