[webkit-efl] Few change suggestions in EFL port

Lucas De Marchi lucas.demarchi at profusion.mobi
Mon Apr 23 08:04:16 PDT 2012

On Mon, Apr 23, 2012 at 12:02 PM, Tomasz Morawski
<t.morawski at samsung.com> wrote:
> Hi,
>> If it's internal header, don't install it.
> Yes, it is a good solution for end user and it works. But base on what
> do you know which header is internal or not if you consider programmer
> point of view?
> If we consider files name we have two header files that are private.
> Other files should be public but it is not true. Few other files are
> also private but without proper name (*_private.h or *_internal.h) you
> have to check content of these files or some configuration files to
> check if they are public or internal. I know now everybody knows that
> ewk_tiled_model.h or other "private header" are private in real but it is
> very not consistent and looks very messy for me and it doesn't look
> consistent. Every now person who would like to contribute to this port
> have to know that.

As I said, name it *_private.h

Lucas De Marchi

More information about the webkit-efl mailing list