[webkit-efl] ewk_view settings implementation

[Gyuyoung Kim]

Hello Mikhail,

In my humble opinion, this is able to reduce code size of ewk_view.cpp. GTK
port has two APIs to control setting options as well.

-- Gyuyoung.

> -----Original Message-----
> From: webkit-efl-bounces at lists.webkit.org [mailto:webkit-efl-
> bounces at lists.webkit.org] On Behalf Of Pozdnyakov, Mikhail
> Sent: Tuesday, April 03, 2012 8:22 PM
> To: webkit-efl at lists.webkit.org
> Subject: [webkit-efl] ewk_view settings implementation
> 
> Hello,
> 
>  I am implementing now LayoutTestController::overridePreference method for
> EFL
> https://bugs.webkit.org/show_bug.cgi?id=83007.
> 
> I've noticed that each ewk_view related setting (web preference) is
> currently present in ewk_view as a separate function (see functions
> starting with ewk_view_setting_... )
> 
> In order to implement LayoutTestController::overridePreference I will need
> to add more ewk_view_setting_ functions to the ewk_view (as not all the
> settings are present there). That will affect the existing API and
> will look quite ugly.
> 
>  Don't you think it would be better to have two common methods (getter and
> setter) for all the web preferences like :
> 
> Eina_Bool  ewk_view_setting_set(Evas_Object *o,  const char* property,
> const Eina_Value* value );
> and
> Eina_Bool ewk_view_setting_get(const Evas_Object *o,  const char*
property,
> Eina_Value* value );
> 
> I could do such refactoring  within the  bug83007.
> 
> Could  you  please tell  your opinion about my proposal?
> 
> 
> BR,
> Mikhail
> 
> ---------------------------------------------------------------------
> Intel Finland Oy
> Registered Address: PL 281, 00181 Helsinki
> Business Identity Code: 0357606 - 4
> Domiciled in Helsinki
> 
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
> 
> _______________________________________________
> webkit-efl mailing list
> webkit-efl at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-efl