[webkit-efl] I want to change *.c to *.cpp

Raphael Kubo da Costa kubo at profusion.mobi
Fri Sep 23 21:05:28 PDT 2011


Ryuan Choi <ryuan.choi at samsung.com> writes:

>>
>> Ok, committed in r63568 of EFL.
>
> Thank you.
>
> Attached file is simple diff after renaming for easy review.

Do you really need the extern "C" declarations in the headers? This code
will only be used by C++ files.

And I dislike using typeof here, as it will really break the build for
anything that is not gcc or clang. I suggest getting rid of the macros
(you could even turn them into proper template functions) or passing
another parameter to them specifying the data type.



More information about the webkit-efl mailing list