[webkit-efl] Coding style issue in EFL port

Gyuyoung Kim gyuyoung.kim at samsung.com
Wed Sep 14 02:41:42 PDT 2011


Hello all,

As you may know, ewk files are .cpp files, except for two
files(ewk_tiled_matrix.c and ewk_tiled_model.c). 
It means we have to use C++ coding style in .cpp files. However, it looks
efl ports are using mixed C and C++
coding style. I think we need to use C++ coding style in efl port except for
public APIs.

In addition, if port implementation is compiled by C++ compiler, reviewers
prefer to use C++ coding style 
for port implementation, except for platform specific implementation.

If nobody oppose my opinion, I'd like to file bugs for this issue, then I
prepare patches for that bugs.
Because I have lots of interests in coding style since before.

In Bug 67705, Kubo suggested that it is better to fix this problem together
when other bugs are reviewed.
But, I heared that reviewers are concerning this problem now. So, I would
like to fix this issue as soon as
possible. Furthermore, demarchi already suggested we should use C++ coding
style in our implementation.
https://bugs.webkit.org/show_bug.cgi?id=67705 

Though there are many difficulties, IMHO, we need to use *class* for port
implementation like qt port eventually.

- Gyuyoung



More information about the webkit-efl mailing list