[webkit-efl] Issues from static program analysis tool(s)

[Kangil Han]

Dear EFL developers,
 
I am writing this to hear your voices on the issues from static program
analysis tool.
'Coverity Static Analysis' can be a tool of those.
 
For example, lately I've got a below report.
There should be null check for 'o' in 'EWK_VIEW_SD_GET(o, ptr)' macro.
 
This is the whole source code for this macro.
 
#define EWK_VIEW_SD_GET(o, ptr)                                 \
    Ewk_View_Smart_Data* ptr =
(Ewk_View_Smart_Data*)evas_object_smart_data_get(o)
 
If we only look at this macro, report seems clear.
But, when it comes to look at 'evas_object_smart_data_get' function, this
point is not so clear.
This is because 'evas_object_smart_data_get' function can handle NULL
argument of 'o'.
However, if we should have strict view in programming, this report makes
sense.
 
I am looking forward to hearing your opinion on handling this kind of stuff.
 
Thanks and regards,
Kangil
 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-efl/attachments/20110728/db336b05/attachment.html>