[webkit-efl] Scope of 'ewk_util.h'

[Rafael Antognolli]

Hello Gyuyoung and Ryuan!

Long time no see! :-)

On Tue, Jul 12, 2011 at 4:05 AM, Gyuyoung Kim <gyuyoung.kim at samsung.com> wrote:
> It looks role of “ewk_util_image_from_cairo_surface_add()” APIs is to get
> image from cairo surface.
> I also don’t know why the APIs was created. I think Profusion guys may know
> the reason.

The reason is that ewk_history.cpp and ewk_settings.cpp use this
function to create an Evas_Object of type image from the cairo
surface. This is useful when creating a thumbnail, or an icon for that
page. Look for this function on these files and you will understand.

> Anyway, I think we don’t need to open ewk_util.h unless ewk_util has
> valuable APIs.

I agree.

> - Gyuyoung
>
> From: webkit-efl-bounces at lists.webkit.org
> [mailto:webkit-efl-bounces at lists.webkit.org] On Behalf Of Ryuan Choi
> Sent: Tuesday, July 12, 2011 4:00 PM
> To: 한강일
> Cc: webkit-efl at lists.webkit.org
> Subject: Re: [webkit-efl] Scope of 'ewk_util.h'
>
>
>
>> Otherwise, ‘EAPI’ should be added in front of return type.
>
>
>
> ewk_util.h is not public now.
>
> I saw bugs to enable it as public, but I am not sure.
>
>
>
> Does we have any reasons to make EAPI?
>
> IMO, we'd better to remove it from EWebKit_HEADERS.

Not sure now why this file is in EWebKit_HEADERS but I think removing
it from there is probably a good idea.

Regards,
-- 
Rafael Antognolli
ProFUSION embedded systems
http://profusion.mobi