[webkit-dev] Update commit log template to add placeholder for explanation of why a patch fixes a bug

David Kilzer ddkilzer at webkit.org
Thu Nov 17 16:42:22 PST 2022

On Nov 17, 2022, at 3:17 PM, Michael Catanzaro <mcatanzaro at gnome.org> wrote:

> On Thu, Nov 17 2022 at 02:48:04 PM -0800, Ryosuke Niwa <rniwa at apple.com> wrote:
>> But every change in WebKit comes with a Bugzilla bug.
> Certainly most do, but some counterexamples:
> * Unreviewed build fixes sometimes do not reference a bug
> * When fixing a new compiler warning or build failure, I often reference the bug that introduced the problem, rather than reporting a new one just to have a new hyperlink for the commit message
> * We probably don't need a bug report for stuff like "update my email address in contributors.json" or "fix typo in comment”

Yes, this is why I stated this in the original message:

>>> Note that the line may be simply be deleted when it doesn’t apply (such as gardening, a build fix, etc.).

I don’t think it’s too burdensome to delete a couple lines of text for the above kinds of fixes if the result is better commit messages overall.


More information about the webkit-dev mailing list