[webkit-dev] Problems with code review tool

Aakash Jain aakash_jain at apple.com
Wed Sep 23 15:18:02 PDT 2020


Interesting. I haven't noticed such problem myself and wasn't aware of this issue. I was aware that the EWS status-bubble loading time has been increasing steadily as we have been increasing number of EWS queues. Tracked in https://bugs.webkit.org/show_bug.cgi?id=214821. I will prioritize fixing it.

Also bugs.webkit.org loads ews status-bubbles from ews.webkit.org in an iframe. I never noticed any issue on bugs.webkit.org itself because of slow loading of status-bubble. It would be interesting to know if this is a browser specific issue.

Thanks
Aakash

> On Sep 23, 2020, at 5:39 PM, Ken Russell <kbr at google.com> wrote:
> 
> Thanks Saam for your reply.
> 
> Unfortunately this happens nearly every time I use the code review tool.
> 
> Aakash, since this seems to be related to the EWS, is it something you might be able to debug? I also frequently see bugs.webkit.org <http://bugs.webkit.org/> tabs display the spinner forever, and it seems to be caused by loading resources from ews.webkit.org <http://ews.webkit.org/>. It's likely the same problem.
> 
> Thanks,
> 
> -Ken
> 
> 
> 
> On Tue, Sep 22, 2020 at 7:25 AM Saam Barati <sbarati at apple.com <mailto:sbarati at apple.com>> wrote:
> Hi Ken,
> 
> I think this is a known problem. Unfortunately, this happens to me a few times a year as well.
> 
> - Saam
> 
>> On Sep 21, 2020, at 2:26 PM, Ken Russell <kbr at google.com <mailto:kbr at google.com>> wrote:
>> 
>> Hi,
>> 
>> Often when I publish code reviews on bugs.webkit.org <http://bugs.webkit.org/>, my browser tab gets stuck waiting for ews.webkit.org <http://ews.webkit.org/>. Reloading the bug shows my comments, but because the submission doesn't complete, the review comments are still treated as pending by the tool, so publishing again causes duplicates.
>> 
>> Has anyone else run into this?
>> 
>> (My browser is Chrome on macOS.)
>> 
>> Thanks,
>> 
>> -Ken
>> 
>> 
>> -- 
>> I support flexible work schedules, and I’m sending this email now because it is within the hours I’m working today.  Please do not feel obliged to reply straight away - I understand that you will reply during the hours you work, which may not match mine. (credit: jparent@)
>> 
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org <mailto:webkit-dev at lists.webkit.org>
>> https://lists.webkit.org/mailman/listinfo/webkit-dev <https://lists.webkit.org/mailman/listinfo/webkit-dev>
> 
> 
> 
> -- 
> I support flexible work schedules, and I’m sending this email now because it is within the hours I’m working today.  Please do not feel obliged to reply straight away - I understand that you will reply during the hours you work, which may not match mine. (credit: jparent@)
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20200923/310c9788/attachment.htm>


More information about the webkit-dev mailing list