[webkit-dev] Clearing old reviews from the queue

Dean Jackson dino at apple.com
Sun Feb 16 20:48:38 PST 2020

> On 16 Feb 2020, at 17:46, Alexey Proskuryakov <ap at webkit.org> wrote:
>> 16 февр. 2020 г., в 7:52, Dean Jackson <dino at apple.com> написал(а):
>> Does anyone oppose clearing all review requests that are older than 6 months? (or 1 year?)
> Looking at ancient patches in the review queue, quite a few look like they should still work (e.g. adding new tests). So said that we are not keeping up with reviews, even for simple patches.

It is very sad.

>> I tried to use the bugzilla API to do this, but I couldn't work out how to detect the attachment state properly. I looked at the source code for the queue page and it uses custom SQL :)
> What were you trying to do, and how far did you get?

I started explaining to you where I failed, which caused me to read the documentation again, and I think I've now got it. I thought that the review status was kept in a side table, but it's not.

Basically I now have a script that:

- for each open bug
  - for each attachment
    - if !is_patch, continue
    - if is_obsolete, continue
    - for each flag
      - if name is "r" and status is "?"
        - if creation_time is older than 1 year
          - Set flag to r- and leave a "sorry we missed you" message
    - if creator is "ap at webkit.org <mailto:ap at webkit.org>"
      - Set flag to r+

So, if we're happy with the 1 year timeout, I'll run this.

> - Alexey
>> (It's easy to do with the GitHub API)
>> Dean
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> https://lists.webkit.org/mailman/listinfo/webkit-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20200216/4a811edf/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3617 bytes
Desc: not available
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20200216/4a811edf/attachment.bin>

More information about the webkit-dev mailing list