[webkit-dev] Standard process for exporting new WPT tests?
foolip at chromium.org
Thu May 24 03:22:45 PDT 2018
On Wed, May 23, 2018, 23:43 youenn fablet <youennf at gmail.com> wrote:
> Le mer. 23 mai 2018 à 14:11, Frédéric Wang <fwang at igalia.com> a écrit :
>> On 23/05/2018 22:50, Ryosuke Niwa wrote:
>> > As we have preciously discussed, we should NEVER commit new tests into
>> > LayoutTests/imported/w3c/web-platform-tests.
> Ryosuke, correct me if I am wrong, I think you are pointing out the
> following rule:
> Changes to LayoutTests/imported/w3c/web-platform-tests tests should land
> first in WPT repository, then in WebKit repository.
Oh, that is surprising.
https://github.com/w3c/web-platform-tests/pull/10964 is a recent WebKit
export, and https://trac.webkit.org/changeset/231788/webkit did modify the
test in place. Do you mean that the WPT PR was merged first, or should be
in general? Chromium and Gecko do it in the other order, and I'd be
interested to understand the trade-offs of flipping the order.
Any process like this where changes end up in WebKit trunk via anything
except a full WPT import will mean that divergence is possible. In
Chromium, regular imports are the safeguard that will eventually resolve
any issuesinvolves. In practice, much to my surprise, we've really never
had something funny happen due to the temporary divergence the process
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the webkit-dev