[webkit-dev] CSS Logical Properties and Values

Michael Catanzaro mcatanzaro at igalia.com
Tue Aug 21 19:47:04 PDT 2018


On Tue, Aug 21, 2018 at 7:56 PM, Oriol Brufau <obrufau at igalia.com> 
wrote:
> So I will try a compile flag instead. But there are some Web Platform
> Tests for the new properties, and I would like them to pass.
> Is there a way to tell the testbot to compile with this flag?

If you absolutely must add a new compile flag... then after adding it 
to WebKitFeatures.cmake, you can add enable it like so in 
OptionsGTK.cmake:

WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEDIA_STREAM PRIVATE 
${ENABLE_EXPERIMENTAL_FEATURES})
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SERVICE_WORKER PRIVATE 
${ENABLE_EXPERIMENTAL_FEATURES})
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_RTC PRIVATE 
${ENABLE_EXPERIMENTAL_FEATURES})

It has to be done separately for each port that wants the experimental 
feature enabled on bots.

This is discouraged, of course. It's better if you don't need a build 
flag at all. But that is how you can do it if you can't find another 
solution to this CSS properties issue.

Michael



More information about the webkit-dev mailing list