[webkit-dev] Formatting style for inline comments in Python code

Aakash Jain aakash_jain at apple.com
Wed Oct 25 14:58:54 PDT 2017

As Ryosuke said, we can modify check-webkit-style and in-fact I will update that if we decide to use Webkit style for this case.

Does anyone else has any opinion/preference for this?


> On Oct 25, 2017, at 12:22 PM, Brian Burg <bburg at apple.com> wrote:
> In this case, I always prefer the PEP8 rules, because check-webkit-style will complain if you don't do so.
> Brian
>> 2017/10/25 午後0:13、Aakash Jain <aakash_jain at apple.com <mailto:aakash_jain at apple.com>>のメール:
>> Hi All,
>> There is one case in which Webkit style guidelines and Python style guidelines do not match. This is about spacing before inline comments.
>> WebKit style guidelines (https://webkit.org/code-style-guidelines/#comments-eol <https://webkit.org/code-style-guidelines/#comments-eol>) says: "Use only one space before end of line comments and in between sentences in comments."
>> Python PEP8 style guidelines (https://www.python.org/dev/peps/pep-0008/#inline-comments <https://www.python.org/dev/peps/pep-0008/#inline-comments>) says: "Inline comments should be separated by at least two spaces from the statement."
>> Should we use "one space" or "two spaces" before the inline comments in python code inside Webkit?
>> Thanks
>> Aakash
>> Reference: https://bugs.webkit.org/show_bug.cgi?id=171506 <https://bugs.webkit.org/show_bug.cgi?id=171506>_______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org <mailto:webkit-dev at lists.webkit.org>
>> https://lists.webkit.org/mailman/listinfo/webkit-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20171025/0291837f/attachment.html>

More information about the webkit-dev mailing list