[webkit-dev] Dead code in webkitpy runtests.py

Alexey Proskuryakov ap at webkit.org
Wed Nov 1 16:06:16 PDT 2017

I think that we would still like to have a unified way to run tests. Right now, even knowing whether a particular script or build step is covered by tests is not straightforward.

At the same time, I think that the tiny subset of tests that webkit-patch used to run wasn't meaningful. Specifically, those were bindings tests and JSC API tests. These make even less sense in the EWS context, as the results were ignored if I remember correctly.

- Alexey

> 1 нояб. 2017 г., в 11:01, Aakash Jain <aakash_jain at apple.com> написал(а):
> Hi Everyone,
> Inside webkitpy, in tool/steps/runtests.py there is code to run various kind of tests (JSC, bindings, webkitpy, webkitperl, layout-tests) which seems like dead code. This code is not used by EWS (since ews pass --non-interactive argument to webkit-patch). 
> I believe the original intention of this code was to have a single command to execute all our test-suites. Is there anyone who uses this functionality, by manually running webkit-patch command with "--build-and-test --test" arguments with an intention of running all possible test-suites?
> If not, I am considering to remove this dead code to clean-up webkitpy.
> References: https://bugs.webkit.org/show_bug.cgi?id=178608 <https://bugs.webkit.org/show_bug.cgi?id=178608>, https://bugs.webkit.org/show_bug.cgi?id=178599 <https://bugs.webkit.org/show_bug.cgi?id=178599>
> Thanks
> Aakash
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20171101/97affcf7/attachment.html>

More information about the webkit-dev mailing list