[webkit-dev] Dead code in webkitpy runtests.py

Aakash Jain aakash_jain at apple.com
Wed Nov 1 11:01:05 PDT 2017


Hi Everyone,

Inside webkitpy, in tool/steps/runtests.py there is code to run various kind of tests (JSC, bindings, webkitpy, webkitperl, layout-tests) which seems like dead code. This code is not used by EWS (since ews pass --non-interactive argument to webkit-patch). 

I believe the original intention of this code was to have a single command to execute all our test-suites. Is there anyone who uses this functionality, by manually running webkit-patch command with "--build-and-test --test" arguments with an intention of running all possible test-suites?

If not, I am considering to remove this dead code to clean-up webkitpy.

References: https://bugs.webkit.org/show_bug.cgi?id=178608 <https://bugs.webkit.org/show_bug.cgi?id=178608>, https://bugs.webkit.org/show_bug.cgi?id=178599 <https://bugs.webkit.org/show_bug.cgi?id=178599>

Thanks
Aakash
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20171101/b53e7848/attachment.html>


More information about the webkit-dev mailing list