[webkit-dev] WEB_TIMING enabled on all ports - let's remove the flag?
weinig at apple.com
Tue Aug 1 14:48:58 PDT 2017
> On Aug 1, 2017, at 6:57 AM, Dean Jackson <dino at apple.com> wrote:
>> On 24 Jul 2017, at 22:44, Brian Burg <bburg at apple.com> wrote:
>> Hi WebKittens,
>> In WebKit, the various web-exposed timing APIs–Resource Timing, User Timing, and Navigation Timing are guarded by the ENABLE_WEB_TIMING feature flag.
>> It seems that ENABLE_WEB_TIMING is turned on for Xcode and CMake build systems by default, and we have not experienced any fallout from shipping these features in Safari Technology Preview. I think it’s time to remove the feature flag. Are there any objections? Is there a port in-tree that’s compiling without this feature?
>> If I don’t hear anything, the flag’s removal will be tracked in <https://bugs.webkit.org/show_bug.cgi?id=174795>.
> In general I think we should be more enthusiastic about removing feature flags that are guarding core parts of the Web platform. Web Timing is a great example.
> Some others I see:
I think WebGL is still not supported on Windows in WebKitLegacy, so we may need to keep that one.
I’d like to add ENABLE_VIDEO to that list, given how core it is to the platform, and how many other features depend on it.
More information about the webkit-dev