[webkit-dev] forwarding headers and CMake

Martin Robinson mrobinson at webkit.org
Tue Jul 28 18:06:35 PDT 2015


I think this might cause issues, because it requires the forwarding
headers be regenerated when any of the target headers change. Why does
Windows need this change? Are the headers being copied for some
packaging purpose? If so, perhaps that can be a separate step specific
to Windows.

--Martin

On Tue, Jul 28, 2015 at 6:03 PM, Alex Christensen
<achristensen at apple.com> wrote:
> In my work getting CMake working on Windows, I discovered a subtle difference in how forwarding headers are made.  In the existing build system, a forwarding header contains the entire contents of the original header.  In the current CMake build, the WEBKIT_CREATE_FORWARDING_HEADERS macro creates lots of one line files that #include the original file.
>
> For example, my JSBase.h forwarding header contains only this one line:
> #include “JavaScriptCore/API/JSBase.h”
>
> In order to switch the Windows build over to use CMake, I’m pretty sure we would need the entire contents of the headers to be copied to the build directory.  Would changing this build behavior cause a problem for the GTK or EFL ports?  If so, I would probably make the forwarding headers macros port specific.
>
> Alex
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev


More information about the webkit-dev mailing list