[webkit-dev] Comment on the bug & email author/reviewer before reverting a patch

Tim Horton timothy_horton at apple.com
Wed Jul 9 12:35:43 PDT 2014


> On Jul 9, 2014, at 12:10 PM, Maciej Stachowiak <mjs at apple.com> wrote:
> 
> 
> Could we teach webkitbot to do an appropriate notification with a waiting period? Either as part of rollout or add a new command to do it.

It already does. The “waiting period” is defined by when the person who asked for the rollout sets the cq+ bit on the rollout patch.

>  - Maciej
> 
>> On Jul 9, 2014, at 11:40 AM, Ryosuke Niwa <rniwa at webkit.org> wrote:
>> 
>> Yes.  The point is to do these things before telling webkitbot to rollout a patch.
>> 
>> - R. Niwa
>> 
>> 
>> On Wed, Jul 9, 2014 at 11:07 AM, Simon Fraser <simon.fraser at apple.com> wrote:
>> On Jul 9, 2014, at 7:43 AM, Ryosuke Niwa <rniwa at webkit.org> wrote:
>> 
>>> Hi all,
>>> 
>>> This is a friendly remainder that you should
>>> comment on the associated bug
>>> email the patch author and the reviewer who reviewed the patch
>>> before rolling out / reverting a patch.
>> 
>> If you use webkitbot to roll out, is this necessary?
>> 
>> Simon
>> 
>> 
>> _______________________________________________
>> webkit-dev mailing list
>> webkit-dev at lists.webkit.org
>> https://lists.webkit.org/mailman/listinfo/webkit-dev
> 
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-dev/attachments/20140709/8d5c611e/attachment.html>


More information about the webkit-dev mailing list