<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><blockquote type="cite"><div>On Jul 9, 2014, at 12:10 PM, Maciej Stachowiak <<a href="mailto:mjs@apple.com">mjs@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div><br></div>Could we teach webkitbot to do an appropriate notification with a waiting period? Either as part of rollout or add a new command to do it.</div></div></blockquote><div><br></div><div>It already does. The “waiting period” is defined by when the person who asked for the rollout sets the cq+ bit on the rollout patch.</div><br><blockquote type="cite"><div><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div> - Maciej<br><div><br><div><blockquote type="cite"><div>On Jul 9, 2014, at 11:40 AM, Ryosuke Niwa <<a href="mailto:rniwa@webkit.org">rniwa@webkit.org</a>> wrote:</div><br class="Apple-interchange-newline"><div><div dir="ltr">Yes. The point is to do these things before telling webkitbot to rollout a patch.<div class="gmail_extra"><br clear="all"><div>- R. Niwa</div>
<br><br><div class="gmail_quote">On Wed, Jul 9, 2014 at 11:07 AM, Simon Fraser <span dir="ltr"><<a href="mailto:simon.fraser@apple.com" target="_blank">simon.fraser@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><div>On Jul 9, 2014, at 7:43 AM, Ryosuke Niwa <<a href="mailto:rniwa@webkit.org" target="_blank">rniwa@webkit.org</a>> wrote:<br><div><br><blockquote type="cite"><div dir="ltr">
Hi all,<div><br></div><div>This is a friendly remainder that you should</div><div><ul><li>comment on the associated bug</li><li>email the patch author and the reviewer who reviewed the patch</li></ul></div><div>
before rolling out / reverting a patch.<br></div></div></blockquote></div><br></div><div>If you use webkitbot to roll out, is this necessary?</div><span><font color="#888888"><div><br></div><div>Simon</div>
<div><br></div></font></span></div>
</blockquote></div><br></div></div>
_______________________________________________<br>webkit-dev mailing list<br><a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br><a href="https://lists.webkit.org/mailman/listinfo/webkit-dev">https://lists.webkit.org/mailman/listinfo/webkit-dev</a><br></div></blockquote></div><br></div></div></div>
_______________________________________________<br>webkit-dev mailing list<br><a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>https://lists.webkit.org/mailman/listinfo/webkit-dev<br></div></blockquote></div><br></body></html>