[webkit-dev] PSA: please sort WebCore.exp.in when you change it
timothy_horton at apple.com
Mon Jul 7 14:05:18 PDT 2014
> On Jul 7, 2014, at 1:51 PM, Bem Jones-Bey <bjonesbe at adobe.com> wrote:
> On Jul 7, 2014, at 11:55 , Tim Horton <timothy_horton at apple.com> wrote:
>>> On Jul 7, 2014, at 11:41 AM, Simon Fraser <simon.fraser at apple.com> wrote:
>>> We have a handy script that sorts the export file; please use it whenever you modify WebCore.exp.in:
>>> ./Tools/Scripts/sort-export-file Source/WebCore/WebCore.exp.in
>> It’s also smart enough to require no arguments at all, and just sorts all of them!
> Any reason that we don't have check-webkit-style fail if these files aren't properly sorted?
I don’t think there’s a *reason* besides a lack of implementation. Seems like it would be a good thing :)
More information about the webkit-dev