[webkit-dev] Should we explicitly disallow indentation to align lines or add an example?

Zoltan Horvath zoltan at webkit.org
Tue Jan 21 19:15:40 PST 2014


Hi there,

I think the 4 spaces indentation doesn't make the code harder to read.

If we stay with that, it will be more consistent in long term, since
otherwise you'd allow almost random-size indentation, based on the
particular code part.

<Zoltan>

On Tue, Jan 21, 2014 at 5:54 PM, Martin Robinson <mrobinson at webkit.org> wrote:
> On Tue, Jan 21, 2014 at 5:13 PM, Ryosuke Niwa <rniwa at webkit.org> wrote:
>
>> I realize our style guideline DOES state the indentation must be done by 4
>> spaces but should we also explicitly prohibit using indentations for
>> alignment?
>>
>> Correct:
>> someFunction(someLongArgument,
>>     someOtherLongArgument);
>>
>> Wrong:
>> someFunction(someLongArgument,
>>              someOtherLongArgument);
>
> check-webkit-style will give an error about this now, so I think it
> makes sense to reflect it in the style guide or change
> check-webkit-style.
>
> --Martin
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev


More information about the webkit-dev mailing list